Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Code style check should be automated. I do not accept discussions on style in PR in my team besides pointing out obvious deviations which should be automated. Discussion on that should be way before making PR.

Architectural changes/discussion should be discussed by developers way before PR on slack or in a call. Most features should not change architecture and team should make effort to align architecture all the time at least before someone makes PR. Unless of course PR is PoC to showcase approach.



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: